On Thu, 10 Mar 2011, Abhijeet Dharmapurikar wrote:

Thomas Gleixner wrote:

quoted

On Tue, 8 Mar 2011, Abhijeet Dharmapurikar wrote:

quoted

quoted

ack is called before mask and it
should never be called when the interrupt is masked.

I didnt quite understand this comment. handle_level_irq calls mask_ack
which
masks the interrupt and then acks it. In this case the ack is called after
the

Indeed, sorry. So the right way to deal with that is to provide a
mask_ack() callback which does it in the correct order for your
HW. That way you avoid all the local state storage.

Yes however while updating the code I noticed that I would need to keep
account of all the interrupts enabled and all the interrupts marked wakeup.
This aids in switching to the wakeup set in the suspend callback and the
enabled set in the resume callback. I will update the resume callback to
enable the interrupts in irqs_allowed(the local state storage) in the next
patch (my current patch does not do that).

IOW I need to keep the local state storage.

Wrong. The interrupts are disabled and reenabled by the core code and
not by some extra suspend/resume callbacks in your driver. The core
checks those marked as IRQ_WAKE, the wake callback to the irq chip is
only there if you need to set up some hardware register in order to
make the wake functionality work. So again, you don't need local state
as the core tracks the state for you.

Thanks,

	tglx