On Thu, Mar 03, 2011 at 11:42:42AM +0800, Viresh KUMAR wrote:

On 03/02/2011 10:16 PM, Koul, Vinod wrote:

quoted

On Mon, 2011-02-28 at 16:11 +0530, Viresh Kumar wrote:

[...]

quoted

quoted

 drivers/dma/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 1c28816..95c7db7 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig

@@ -82,7 +82,6 @@ config INTEL_IOP_ADMA
 
 config DW_DMAC
 	tristate "Synopsys DesignWare AHB DMA support"
-	depends on AVR32

Shouldn't you be adding a corresponding depends on new arch? And since
this supports old arch as well, it should say depends on both...

Why should this driver be dependent on ARM or AVR32? It can be present
on any other arch too.. So i thought removing this dependency all together
is better.

There could be a dependency on HAVE_CLK as it uses clock APIs.

-- 
regards
Shiraz