Thread (28 messages) 28 messages, 7 authors, 2011-03-07

[PATCH 6/8 resend] dw_dmac: Mark all tx_descriptors with DMA_CRTL_ACK after xfer finish

From: viresh kumar <hidden>
Date: 2011-02-28 15:04:06
Also in: lkml

On 2/28/11, Sergei Shtylyov [off-list ref] wrote:
Hello.

On 28-02-2011 13:41, Viresh Kumar wrote:
quoted
dwc_desc_get checks all descriptors for DMA_CTRL_ACK before allocating
them for
transfers. And descriptors are not marked with DMA_CRTL_ACK after transfer
finishes. Thus descriptor once used is not usable again. This patch marks
descriptors with DMA_CRTL_ACK after dma xfer finishes
quoted
Signed-off-by: Viresh Kumar<redacted>
---
  drivers/dma/dw_dmac.c |    7 +++++++
  1 files changed, 7 insertions(+), 0 deletions(-)
quoted
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index c40b89f..01f783d 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -196,6 +196,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc,
struct dw_desc *desc)
  	dma_async_tx_callback		callback;
  	void				*param;
  	struct dma_async_tx_descriptor	*txd =&desc->txd;
+	struct dw_desc	*child;
    Shouldn't this varaible name be aligned with the above variable names?
Should be. Will take care of this while resending this patch series,
after getting all
review comments.

--
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help