Thread (9 messages) 9 messages, 3 authors, 2011-03-01

[PATCH v6 1/1] PRUSS UIO driver support

From: Thomas Gleixner <hidden>
Date: 2011-03-01 09:53:34
Also in: lkml

On Tue, 1 Mar 2011, TK, Pratheesh Gangadhar wrote:
quoted
On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote:
quoted
+
+		/* Register PRUSS IRQ lines */
+		p->irq = IRQ_DA8XX_EVTOUT0 + cnt;
+		p->handler = pruss_handler;
+
+		ret = uio_register_device(&dev->dev, p);
+
+		if (ret < 0)
+			goto out_free;
+	}
+
+	spin_lock_init(&lock);
That's too late. uio_register_device() enables the irq, and your spin_lock
is not ready at that time.
This is ok in this context as "modprobe uio_pruss" is pre-requisite for
running PRUSS firmware and without firmware running PRUSS won't
generate interrupts. Actually PRUSS INTC is not setup till we start
user application.
No, it's not. If you enable interrupts you have to be prepared for
getting one whether the device mask is enabled or not. It's that
simple.

Thanks,

	tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help