Thread (9 messages) 9 messages, 3 authors, 2011-03-01

[PATCH v6 1/1] PRUSS UIO driver support

From: Hans J. Koch <hidden>
Date: 2011-02-28 21:27:36
Also in: lkml

On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote:
+
+		/* Register PRUSS IRQ lines */
+		p->irq = IRQ_DA8XX_EVTOUT0 + cnt;
+		p->handler = pruss_handler;
+
+		ret = uio_register_device(&dev->dev, p);
+
+		if (ret < 0)
+			goto out_free;
+	}
+
+	spin_lock_init(&lock);
That's too late. uio_register_device() enables the irq, and your spin_lock
is not ready at that time.
+	platform_set_drvdata(dev, info);
+	return 0;
+
+out_free:
+	pruss_cleanup(dev, info);
+	return ret;
+}
Thanks,
Hans
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help