Thread (18 messages) 18 messages, 6 authors, 2011-02-22
STALE5603d

[PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

From: Russell King - ARM Linux <hidden>
Date: 2011-02-21 11:06:24
Also in: linux-mmc

On Mon, Feb 21, 2011 at 05:54:55PM +0800, Richard Zhao wrote:
+	if (host->quirks & SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO) {
+		if (readl(host->ioaddr + SDHCI_VENDOR_SPEC) & 0x2)
+			writel(readl(host->ioaddr + SDHCI_VENDOR_SPEC) & ~0x2,
+					host->ioaddr + SDHCI_VENDOR_SPEC);
Is it necessary to read the register twice, or would:

		u32 val = readl(host->ioaddr + SDHCI_VENDOR_SPEC);
		if (val & 0x02)
			writel(val & ~0x02, host->ioaddr + SDHCI_VENDOR_SPEC);

be clearer and more obvious?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help