[PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO
From: Wolfram Sang <hidden>
Date: 2011-02-21 10:46:08
Also in:
linux-mmc
From: Wolfram Sang <hidden>
Date: 2011-02-21 10:46:08
Also in:
linux-mmc
quoted
quoted
- if (cpu_is_mx35() || cpu_is_mx51()) + if (cpu_is_mx53()) + host->quirks |= SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO;Have you tried it doing it via IO-accessors?Richard Zhu: This quirk is used to fix a mechanism problem in the MMC CMDs execution procedure. It would be very abrupt and ugly, if the IO-accessors are added into these original procedures.
Please don't get it personal, but IMHO it is pretty ugly the way it is now. This quirk is very imx-specific and calling something like SDHCI_VENDOR_SPEC in sdhci.c looks clearly wrong to me. By the way, what does this bit do, the description doesn't say so? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110221/2393fe81/attachment.sig>