Thread (17 messages) flat view 17 messages, 4 authors, 2011-02-15
STALE5661d

[PATCH 1/2] OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg()

From: Jarkko Nikula <hidden>
Date: 2011-02-15 13:59:48
Also in: linux-omap

On Tue, 15 Feb 2011 15:44:27 +0200
David Cohen [off-list ref] wrote:
quoted
quoted
@@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj,
u32 *ra)
? ? ? ?da = iommu_read_reg(obj, MMU_FAULT_AD);
? ? ? ?*ra = da;

- ? ? ? dev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
+ ? ? ? dev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da);
? Note that dev_dbg() will only print something if either DEBUG or
CONFIG_DYNAMIC_DEBUG are defined...
That's my plan.
So it's sure that a developer won't need these error dumps when
receiving an error report? I.e. IOMMU upper level errors give enough
information to start doing own debugging?

Just my 2 cents.

-- 
Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help