[PATCH 1/5] dmaengine: mxs-dma: add dma support for i.MX23/28

Hi Russell,

On Sat, Feb 05, 2011 at 03:33:00PM +0000, Russell King - ARM Linux wrote:

Shawn,

A couple more points below.

On Sat, Feb 05, 2011 at 10:08:12AM +0800, Shawn Guo wrote:

quoted

+	mxs_dma->dev = &pdev->dev;

...

quoted

+	mxs_dma->dma_device.dev = &pdev->dev;

Do you need mxs_dma->dev, or could you just use mxs_dma->dma_device.dev
throughout?

OK.

quoted

+static int __exit mxs_dma_remove(struct platform_device *pdev)
+{
+	return -EBUSY;
+}

As the return code is ignored, it's probably better to omit the remove
function entirely.

OK.

Regards,
Shawn