Thread (10 messages) 10 messages, 4 authors, 2011-02-24

[PATCH v3 1/2] PRUSS UIO driver support

From: TK, Pratheesh Gangadhar <hidden>
Date: 2011-02-24 13:56:19
Also in: lkml

-----Original Message-----
From: Thomas Gleixner [mailto:tglx at linutronix.de]
Sent: Thursday, February 24, 2011 2:24 AM
To: Sergei Shtylyov
Cc: TK, Pratheesh Gangadhar; davinci-linux-open-
source at linux.davincidsp.com; Chatterjee, Amit; gregkh at suse.de; linux-
kernel at vger.kernel.org; hjk at hansjkoch.de; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH v3 1/2] PRUSS UIO driver support

On Wed, 23 Feb 2011, Sergei Shtylyov wrote:
quoted
Hello.

On 23-02-2011 23:25, Thomas Gleixner wrote:
quoted
quoted
+	prussio_virt_addr =
+	    ioremap(regs_prussio->start,
+		    regs_prussio->end - regs_prussio->start + 1);
quoted
Either make those variable names shorter or do:
quoted
        len = regs_prussio->end - regs_prussio->start + 1;
   Or even:

	len = resource_size(regs_prussio);
quoted
        prussio_virt_addr = ioremap(regs_prussio->start, len);
Good point. Forgot about that one :)
Thanks will do this.

Pratheesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help