Thread (3 messages) flat view 3 messages, 3 authors, 2011-01-20
DORMANTno replies

[PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM

From: Jean Pihet <hidden>
Date: 2011-01-20 13:14:40
Also in: linux-omap

On Wed, Jan 19, 2011 at 11:10 PM, Tony Lindgren [off-list ref] wrote:
* Kevin Hilman [off-list ref] [110119 13:37]:
quoted
Kevin Hilman [off-list ref] writes:
quoted
jean.pihet at newoldbits.com writes:
quoted
From: Jean Pihet <redacted>

The new fncpy API is better suited for copying some
code to SRAM at runtime. This patch changes the ad-hoc
code to the more generic fncpy API.

Tested OK on OMAP3 in low power modes (RET/OFF)
using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL.
Compile tested on OMAP1/2 using omap1_defconfig.

Signed-off-by: Jean Pihet <redacted>
Acked-by: Kevin Hilman <redacted>

Boot tested on OMAP1 & OMAP2 as well. ?Note that neither OMAP1 or OMAP2
has had working suspend/resume for a long time now, so I did not test
suspend/resume.
For OMAP2:

Tested-by: Kevin Hilman <redacted>

to test a little more on OMAP2, I just removed the WFI from the
low-level code and tested suspend that way. ?That's enough to be sure
the copied code is copied and executed.

Worked fine on OMAP2420/n810.

For OMAP1, this didn't work and would require more serious hacking on
the OMAP1 suspend path, which I currently have no plans to do.
Boots fine on osk5912 and n800 too:

Tested-by: Tony Lindgren <tony@atomide.com>
Thanks for testing!

Regards,
Jean
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help