[PATCH v3 0/2] kexec: fix probe error codes and error propagation
From: Mukesh Pilaniya <hidden>
Date: 2026-08-21 13:50:22
Also in:
kexec, linux-riscv, lkml, loongarch
While debugging a misleading error on s390x where kexec -s reported "syscall kexec_file_load not available" instead of the actual EINVAL from a kernel command line that exceeded the architecture limit, we found that some kexec image probe functions return -EINVAL instead of -ENOEXEC for format mismatches, and kexec_image_probe_default() has a bug where it returns whatever the last loader returned rather than always returning -ENOEXEC when no loader matches. Patch 1 fixes all probe functions to return -ENOEXEC when they do not recognize the image format. Patch 2 fixes kexec_image_probe_default() to distinguish format mismatches (-ENOEXEC) from real errors (e.g. -ENOMEM), propagating real errors immediately and only continuing to the next loader on -ENOEXEC. kexec-tools patch: https://lore.kernel.org/all/20260814075329.30203-1-mpilaniy@redhat.com/ (local) Signed-off-by: Mukesh Pilaniya <redacted> --- Changes in v3: - Patch 2: rename ret to err and change ret == 0 to !err as suggested by Mike. - Link to v2: https://patch.msgid.link/20260819-mpilaniy-v2-0-95e929ede0e5@redhat.com Changes in v2: - Added patch 2 to fix error propagation in kexec_image_probe_default(), as suggested by Pratyush Yadav. - Link to v1: https://patch.msgid.link/20260813-mpilaniy-v1-1-777d4d0e30f7@redhat.com To: Catalin Marinas <catalin.marinas@arm.com> To: Will Deacon <will@kernel.org> To: Mark Rutland <mark.rutland@arm.com> To: Huacai Chen <chenhuacai@kernel.org> To: WANG Xuerui <kernel@xen0n.name> To: Paul Walmsley <pjw@kernel.org> To: Palmer Dabbelt <palmer@dabbelt.com> To: Albert Ou <aou@eecs.berkeley.edu> To: Alexandre Ghiti <alex@ghiti.fr> To: Andrew Morton <akpm@linux-foundation.org> To: Baoquan He <baoquan.he@linux.dev> To: Mike Rapoport <rppt@kernel.org> To: Pasha Tatashin <pasha.tatashin@soleen.com> To: Pratyush Yadav <pratyush@kernel.org> To: Philipp Rudo <redacted> To: Tao Liu <redacted> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-riscv@lists.infradead.org Cc: kexec@lists.infradead.org --- Mukesh Pilaniya (2): kexec: return -ENOEXEC from image probe functions on mismatch kexec: fix error propagation in kexec_image_probe_default() arch/arm64/kernel/kexec_image.c | 4 ++-- arch/loongarch/kernel/kexec_efi.c | 4 ++-- arch/riscv/kernel/kexec_image.c | 4 ++-- kernel/kexec_elf.c | 4 ++-- kernel/kexec_file.c | 12 +++++++----- 5 files changed, 15 insertions(+), 13 deletions(-) --- base-commit: dd8c49a14f169d58e7a07a2c96fb588f3456efa0 change-id: 20260813-mpilaniy-ffb0cc92c313 Best regards, -- Mukesh Pilaniya [off-list ref]