Thread (10 messages) flat view 10 messages, 5 authors, 2011-01-12
STALE5714d

Revision v1 of 4 in this series.

Revisions (4)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 current
  4. v1 [diff vs current]

[PATCH 2/2] ARM i.MX53 enable LOCO board bootup

From: Yong Shen <hidden>
Date: 2011-01-12 02:46:24

Hi Fabio,

Below is my reply to Baruch, I meant to keep this code here to show
the reset process clearly.
quoted
+     if (ret) {
+             printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
+             return;
+     }
+     gpio_direction_output(SMD_FEC_PHY_RST, 0);
+     gpio_set_value(SMD_FEC_PHY_RST, 0);
This seems to be redundant. gpio_direction_output() has already set the value
to 0.
You are right. But, gpio_set_value is meant to be here to show the
process of fec reset: first pull low and then pull high. And
gpio_direction_output here is for direction configuration although it
has the ability of configure output value.

thanks
Yong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help