Thread (10 messages) flat view 10 messages, 5 authors, 2011-01-12
STALE5714d

Revision v1 of 2 in this series.

Revisions (2)
  1. v1 [diff vs current]
  2. v1 current

[PATCH 0/2] ARM i.MX53 enable SMD and LOCO board bootup

From: Yong Shen <hidden>
Date: 2011-01-11 08:58:26

Hi Baruch,
Code for two (or more) different machines can be shared in the same file. See
for example the code in arch/arm/mach-at91/board-stamp9g20.c which supports
both taskit PortuxG20 and taskit Stamp9G20, and
arch/arm/mach-at91/board-pcontrol-g20.c which is reusing code from these
boards for a third board (PControl G20).

We should avoid code duplication as much as possible, IMO.
I agree the rule you mentioned about: avoid code duplication, and I
also know that one file can hold multiple board definitions. However,
in this case, these two boards were designed for different purpose.
For example, SMD is for smart mobile device, while LOCO is more
generic for multiple usage. As time goes on, the code for each boards
are supposed to be much more different than it is now.
So I still stick on my opinion, hope you can understand.

thanks
Yong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help