Hello Jean,

On Wed, 5 Jan 2011, Jean Pihet wrote:

On Tue, Jan 4, 2011 at 7:48 PM, Paul Walmsley [off-list ref] wrote:

quoted

If the latter, then it might make sense to put these
trace points into the functions that actually change the hardware
registers, e.g., omap2_dflt_clk_{enable,disable}(), etc., since a
clk_enable() on a leaf clock may result in many internal system clocks
being enabled up the clock tree.

I agree with you it is better to track the actual clock changes instead.
I propose to move the tracepoints to omap2_clk_{enable...} which
enables all the clocks irrespectively of the installed handler.

Yes, that is a better place.

Note about the clock handlers: omap2_dflt_clk_enable happens to be the
handler for all controllable clocks but could that change in the
future?

Yes, it certainly could.


- Paul