Thread (55 messages) flat view 55 messages, 4 authors, 2011-01-01
STALE5745d

[PATCH 06/10] ARM: mx28: update clocks for dual fec support

From: baruch@tkos.co.il (Baruch Siach)
Date: 2010-12-29 06:57:34

Hi Shawn,

On Tue, Dec 28, 2010 at 10:55:51PM +0800, Shawn Guo wrote:
quoted hunk ↗ jump to hunk
* Change fec clock registration to use con_id only for looking up,
  so that dual fec driver can find the same clock for both fec0
  and fec1.

* Explicitly call clk_enable for some clocks that have been on to
  reflect the clock status and get usecount updated. Otherwise,
  clocks could be turned off by pair call of clk_enable/clk_disable
  in drivers, because of the incorrect initial usecount.

Signed-off-by: Shawn Guo <redacted>
---
 arch/arm/mach-mxs/clock-mx28.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
index dd6d158..6b77aff 100644
--- a/arch/arm/mach-mxs/clock-mx28.c
+++ b/arch/arm/mach-mxs/clock-mx28.c
@@ -603,7 +603,7 @@ _DEFINE_CLOCK(fec_clk, ENET, DISABLE, &hbus_clk);
 
 static struct clk_lookup lookups[] = {
 	_REGISTER_CLOCK("uart", NULL, uart_clk)
-	_REGISTER_CLOCK("fec.0", NULL, fec_clk)
+	_REGISTER_CLOCK(NULL, "fec_clk", fec_clk)
Looks like a wrong use of the clk API. You should define define two clocks 
"fec.0" and "fec.1".

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help