Hi Lothar,
Thanks for the review.
On Wed, Dec 8, 2010 at 3:25 PM, Lothar Wa?mann [off-list ref] wrote:
Hi,
Shawn Guo writes:
quoted
MXS-based SoCs implements iomux functions in block PINCTRL.
Signed-off-by: Shawn Guo <redacted>
---
Changes for v2:
?- Define iomux_cfg_t as u64
? ? ^^^^^^^^^^^^^^^^^^^^^^^^^
Really?
quoted
+typedef struct pad_desc {
+ ? ? unsigned bank:12;
+ ? ? unsigned pin:20;
+ ? ? unsigned muxsel:8;
+ ? ? unsigned ma:12;
+ ? ? unsigned vol:8;
+ ? ? unsigned pull:4;
+} iomux_cfg_t;
^^^^^^^^^^^^^^^^^
I did not pick the correct word. What I meant is 64 bits. Since this
error is in change log, I would fix it if there is v3 of the patch.
--
Regards,
Shawn