[PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

Hello,

On Monday, August 02, 2010 12:52 PM Russell King wrote:

On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote:

quoted

Well, some of them are indeed unused, but it's not an uncommon practice

in

quoted

kernel and might help future developers.

On the other hand, arch/arm is getting soo big that we need to do
something about this - and one solution is to avoid unnecessary
definitions that we're not using.

Another good idea is to put definitions along side the drivers which
they're relevant to - maybe in a local driver-name.h file which
driver-name.c includes, or maybe even within driver-name.c if they're
not excessive.  This has the advantage of distributing the "bloat" to
where its actually used, and means that the driver isn't dependent so
much on arch/arm or even the SoC itself.

Well, with FIMC driver we just followed the style from other Samsung
drivers. Just take a look at video/s3c-fb or usb/gadget/s3c-hsotg.c.
I personally like to keep the same style for all drivers for Samsung
IPs. Changing the style of all of them requires some amount of work,
that would delay this particular driver even more so we will definitely
miss the merge window.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center