Thread (22 messages) 22 messages, 8 authors, 2010-08-31

[PATCH] mmc: move regulator handling to core

From: Linus Walleij <hidden>
Date: 2010-08-31 12:15:15
Also in: linux-mmc, lkml

2010/8/31 Mark Brown [off-list ref]:
On Sun, Aug 29, 2010 at 05:30:48PM +0200, Linus Walleij wrote:
quoted
2010/8/29 Mark Brown [off-list ref]:
quoted
quoted
This seems like the wrong approach; if there's a problem it'd seem much
better to fix the core code that everything is sharing rather than
factor it out - the location of the code is orthogonal to its
helpfulness.
quoted
I actually did not move the essential regulator bits out just enable/disable,
so that these were in the sites where the regulators were actually
enabled/disabled in respective driver. That makes the internal
regulator reference count do the trick.
I'm not sure what "the sites where the regulators were actually
enabled/disabled in respective driver" are but my understanding was that
there's a bit of an issue here in that the MMC core does not guarantee
balanced enable/disable calls.
Yeah I figured out what you wanted and sent an updated patch, check
it out. I'll just weave in some comments from Adrian and it'll do things
the way you want it I believe.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help