Thread (22 messages) 22 messages, 8 authors, 2010-08-31

[PATCH] mmc: move regulator handling to core

From: Linus Walleij <hidden>
Date: 2010-08-29 15:30:50
Also in: linux-mmc, lkml

2010/8/29 Mark Brown [off-list ref]:
On Sat, Aug 28, 2010 at 04:48:58PM +0200, Linus Walleij wrote:
quoted
2010/8/27 Chris Ball [off-list ref]:
quoted
quoted
Looks like this patch got dropped because of the missing modifications
to arch/arm/mach-omap2/mmc-twl4030.c. ?Are we still interested in the
patch otherwise, and can anyone help with that?
quoted
Actually just before the summer I submitted something not quite similar:
I moved all regulator handling *out* of the MMC core because I didn't
trust the way reference counting was being handled.
This seems like the wrong approach; if there's a problem it'd seem much
better to fix the core code that everything is sharing rather than
factor it out - the location of the code is orthogonal to its
helpfulness.
I actually did not move the essential regulator bits out just enable/disable,
so that these were in the sites where the regulators were actually
enabled/disabled in respective driver. That makes the internal
regulator reference count do the trick.

I can get that patch into shape easily, if for nothing else it's a nice
discussion item.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help