Just a little issue, in your patch you were enabling interface clock in
amba_probe which is called after reading peripheral id registers in
amba_device_register. We need interface clock enabled before reading these
registers.
Rabin already noted this and Russell says he'll fix it before applying the
patch.
Yours,
Linus Walleij