[PATCH v4] GPIO PL061: Adding Clk framework support
From: Linus Walleij <hidden>
Date: 2010-07-13 11:00:51
2010/7/13 Russell King - ARM Linux [off-list ref]:
On Sat, Jul 10, 2010 at 05:36:54PM +0200, Linus Walleij wrote:
quoted
Aha I get it, then it looks good...Is that an Ack for the patch?
Yep! FWIW Acked-by: Linus Walleij <redacted>
I think there's one change I'd like, which is to change "busck" to "apb_pclk" to make it clear what it's referring to.
Looks good.
Also, is there any chance you can convert your platform(s) over to use it before I merge this patch?
I can take a round over the U300 within a few days, Rabin can maybe look at the U8500. In the U300 (maybe the U8500 as well, I don't know OTOH) the APB pclk and e.g. SSPCLK is simply just wired together and connected to the same clock terminal. This means that currently the PCLK is toggled on/off in unison with the SSPCLK all the time already, and it's working. Since that works, it means that we can likely insert amba_bus_clk_[disable|enable] at the same sites that we have this in the current code for the external clocks at the same time, atleast for pl011, pl022 and pl180. Yours, Linus Walleij