[PATCH 2/5] Treo680: remove unused LCD power GPIO
flat view
STALE6253d
REVIEWED: 1 (0M)
From: Marek Vasut <hidden>
Date: 2009-08-31 17:34:51
1 review trailer.
Dne Po 31. srpna 2009 19:25:58 Tom?? ?ech napsal(a):
quoted hunk ↗ jump to hunk
From: Tom?? ?ech <sleep walker@suse.cz> Signed-off-by: Tom?? ?ech <redacted> --- arch/arm/mach-pxa/treo680.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-)diff --git a/arch/arm/mach-pxa/treo680.c b/arch/arm/mach-pxa/treo680.c index 050ad8e..57bccc3 100644 --- a/arch/arm/mach-pxa/treo680.c +++ b/arch/arm/mach-pxa/treo680.c@@ -254,16 +254,9 @@ static int treo680_backlight_init(struct device *dev) ret = gpio_direction_output(GPIO_NR_TREO680_BL_POWER, 0); if (ret) goto err2; - ret = gpio_request(GPIO_NR_TREO680_LCD_POWER, "LCD POWER"); - if (ret) - goto err2; - ret = gpio_direction_output(GPIO_NR_TREO680_LCD_POWER, 0); - if (ret) - goto err3; return 0; -err3: - gpio_free(GPIO_NR_TREO680_LCD_POWER); + err2: gpio_free(GPIO_NR_TREO680_BL_POWER); err:@@ -279,7 +272,6 @@ static int treo680_backlight_notify(int brightness) static void treo680_backlight_exit(struct device *dev) { gpio_free(GPIO_NR_TREO680_BL_POWER); - gpio_free(GPIO_NR_TREO680_LCD_POWER); } static struct platform_pwm_backlight_data treo680_backlight_data = {
Why was that GPIO there before then? Does this have any effect on the boot problems you are experiencing with Centro/T680? Otherwise seems OK to me Acked-by: Marek Vasut <redacted>