Re: [RFC 04/32] parport: PC style parport depends on HAS_IOPORT
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-12-28 10:14:22
Also in:
linux-pci, linux-riscv, lkml
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-12-28 10:14:22
Also in:
linux-pci, linux-riscv, lkml
Hi Niklas, On Mon, Dec 27, 2021 at 5:48 PM Niklas Schnelle [off-list ref] wrote:
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. As PC style parport uses these functions we need to handle this dependency for HAS_IOPORT. Co-developed-by: Arnd Bergmann <arnd@kernel.org> Signed-off-by: Arnd Bergmann <arnd@kernel.org> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Thanks for your patch!
--- a/drivers/parport/Kconfig +++ b/drivers/parport/Kconfig@@ -14,7 +14,6 @@ config ARCH_MIGHT_HAVE_PC_PARPORT menuconfig PARPORT tristate "Parallel port support" - depends on HAS_IOMEM
Why drop this? Don't all other parport drivers depend on it?
help
If you want to use devices connected to your machine's parallel port
(the connector at the computer with 25 holes), e.g. printer, ZIP
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds