On 9/29/2021 12:04 AM, Greg KH wrote:

On Tue, Sep 28, 2021 at 11:01:54AM -0700, Sohil Mehta wrote:

quoted

Is this reasonable or would you still prefer a pointer?

Ok, just document it really well that this is NOT a real address used by
the kernel.  As it is, that's not obvious at all.

Thanks. I'll do that.

And if this crosses the user/kernel boundry, it needs to be __u64 right?

This one doesn't cross the user/kernel boundary. The kernel programs a 
value in this struct for the hardware to consume.

But there might be other places where I have missed that. I'll fix those.

Thanks,
Sohil