Re: [PATCH 1/3] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL
From: Anup Patel <anup@brainfault.org>
Date: 2021-05-24 08:03:27
Also in:
linux-riscv, linux-sunxi, lkml
On Mon, May 24, 2021 at 12:22 PM [off-list ref] wrote:
From: Guo Ren <redacted> Kernel virtual address translation should avoid care asid or it'll cause more TLB-miss and TLB-refill. Because the current asid in satp belongs to the current process, but the target kernel va TLB entry's asid still belongs to the previous process. Signed-off-by: Guo Ren <redacted> Cc: Anup Patel <redacted> Cc: Palmer Dabbelt <redacted>
First of all thanks for doing this series, I had similar changes in mind as follow-up to the ASID allocator. I went through all three patches and at least I don't see any obvious issue but I think we should try testing it more on a few existing platforms. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup
quoted hunk ↗ jump to hunk
--- arch/riscv/include/asm/pgtable.h | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index 78f2323..017da15 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h@@ -135,6 +135,7 @@ | _PAGE_PRESENT \ | _PAGE_ACCESSED \ | _PAGE_DIRTY \ + | _PAGE_GLOBAL \ | _PAGE_CACHE) #define PAGE_KERNEL __pgprot(_PAGE_KERNEL) --2.7.4