[PATCH 12/23] rivafb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

[PATCH 00/23] clean up the code related to ASSERT() · Chunguang Xu <hidden> · 2020-08-27
[PATCH 04/23] fore200e: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 09/23] cachefiles: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 09/23] cachefiles: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-28
[PATCH 08/23] jfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 08/23] jfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
[PATCH 13/23] nvidia: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 15/23] media/staging: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 17/23] 8139too: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 19/23] block/sx8: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 21/23] ext4: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 23/23] ALSA: asihpi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 22/23] rbd: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 20/23] skb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 18/23] net:hns: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 16/23] sym53c8xx: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 14/23] fbdev/cirrusfb:: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 12/23] rivafb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
Re: [PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-28
[PATCH 10/23] btrfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 01/23] include/asm-generic/bug.h: add ASSERT_FAIL() and ASSERT_WARN() wrapper · Chunguang Xu <hidden> · 2020-08-27
[PATCH 07/23] lib/mpi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-28
[PATCH 03/23] KVM: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 05/23] scsi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 02/23] ia64: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27

STALE2101d

From: Chunguang Xu <hidden>
Date: 2020-08-27 10:16:20
Also in: lkml
Subsystem: framebuffer layer, nvidia (rivafb and nvidiafb) framebuffer driver, the rest · Maintainers: Helge Deller, Antonino Daplas, Linus Torvalds

Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT()
may be realized through them, thus reducing code redundancy and
facilitating problem analysis.

Signed-off-by: Chunguang Xu <redacted>
---
 drivers/video/fbdev/riva/fbdev.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index 9b34938..8a2e768 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c

@@ -67,12 +67,7 @@
 #define NVTRACE_LEAVE(...)  NVTRACE("%s END\n", __func__)
 
 #ifdef CONFIG_FB_RIVA_DEBUG
-#define assert(expr) \
-	if(!(expr)) { \
-	printk( "Assertion failed! %s,%s,%s,line=%d\n",\
-	#expr,__FILE__,__func__,__LINE__); \
-	BUG(); \
-	}
+#define assert(expr) ASSERT_FAIL(expr)
 #else
 #define assert(expr)
 #endif

-- 
1.8.3.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help