[PATCH 21/23] ext4: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

[PATCH 00/23] clean up the code related to ASSERT() · Chunguang Xu <hidden> · 2020-08-27
[PATCH 04/23] fore200e: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 09/23] cachefiles: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 09/23] cachefiles: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-28
[PATCH 08/23] jfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 08/23] jfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
[PATCH 13/23] nvidia: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 15/23] media/staging: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 17/23] 8139too: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 19/23] block/sx8: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 21/23] ext4: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 23/23] ALSA: asihpi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 22/23] rbd: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 20/23] skb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 18/23] net:hns: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 16/23] sym53c8xx: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 14/23] fbdev/cirrusfb:: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 12/23] rivafb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
Re: [PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-28
[PATCH 10/23] btrfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 01/23] include/asm-generic/bug.h: add ASSERT_FAIL() and ASSERT_WARN() wrapper · Chunguang Xu <hidden> · 2020-08-27
[PATCH 07/23] lib/mpi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-27
Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · kernel test robot <hidden> · 2020-08-28
[PATCH 03/23] KVM: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 05/23] scsi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27
[PATCH 02/23] ia64: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code · Chunguang Xu <hidden> · 2020-08-27

STALE2101d

From: Chunguang Xu <hidden>
Date: 2020-08-27 10:15:24
Also in: lkml
Subsystem: ext4 file system, filesystems (vfs and infrastructure), the rest · Maintainers: "Theodore Ts'o", Alexander Viro, Christian Brauner, Linus Torvalds

Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT()
may be realized through them, thus reducing code redundancy and
facilitating problem analysis.

Signed-off-by: Chunguang Xu <redacted>
---
 fs/ext4/mballoc.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c0a331e..99976e6 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c

@@ -591,15 +591,7 @@ static inline void mb_group_bb_bitmap_free(struct ext4_group_info *grp)
 
 #ifdef AGGRESSIVE_CHECK
 
-#define MB_CHECK_ASSERT(assert)						\
-do {									\
-	if (!(assert)) {						\
-		printk(KERN_EMERG					\
-			"Assertion failure in %s() at %s:%d: \"%s\"\n",	\
-			function, file, line, # assert);		\
-		BUG();							\
-	}								\
-} while (0)
+#define MB_CHECK_ASSERT(assert) ASSERT_FAIL(assert)
 
 static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
 				const char *function, int line)

-- 
1.8.3.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help