Thread (35 messages) 35 messages, 10 authors, 2018-02-07

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-02-06 22:52:59
Also in: lkml

On Tue, Feb 6, 2018 at 1:37 PM, Dan Williams [off-list ref] wrote:
At that point we're basically just back to the array_ptr() version
that returned a sanitized pointer to an array element.
.. that one does an extra unnecessary 'andq' instead of the duplicated
cmp.  But at least it avoids comparing that 32-bit integer twice, so
it's probably slightly smaller.

(And your code generation is without the "r" -> "ir" fix for the size argument)

Probably doesn't matter. But a "asm goto" would give you at least
potentially optimal code.

            Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help