Thread (68 messages) 68 messages, 8 authors, 2016-03-11

Re: [PATCH 15/18] uprobes: wait for mmap_sem for write killable

From: Oleg Nesterov <oleg@redhat.com>
Date: 2016-02-29 17:12:22
Also in: linux-mm, lkml

On 02/29, Michal Hocko wrote:
quoted hunk ↗ jump to hunk
Ahh, I see. I didn't understand what is the purpose of the warning. Does
the following work for you?
---
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index a79315d0f711..fb4a6bcc88ce 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1470,7 +1470,8 @@ static void dup_xol_work(struct callback_head *work)
 	if (current->flags & PF_EXITING)
 		return;

-	if (!__create_xol_area(current->utask->dup_xol_addr))
+	if (!__create_xol_area(current->utask->dup_xol_addr) &&
+			!fatal_signal_pending(current)
 		uprobe_warn(current, "dup xol area");
 }
Yes, I think this is fine.

Probably deserves a cleanup, but we can do it later.

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help