Re: [PATCH v2 43/44] tty/metag_da: Add metag DA TTY driver
From: Alan Cox <hidden>
Date: 2013-01-07 11:47:43
Also in:
lkml
From: Alan Cox <hidden>
Date: 2013-01-07 11:47:43
Also in:
lkml
Yes. The case I tried was a large write (strace cat /etc/somefile > /dev/ttyDA2) and strace showed a single large write, but it got to the driver in chunks of a dozen or so characters. Is that expected to happen?
Yes it is - the tty mid layer code could do better on this but it's never been much of a priority.
@@ -613,8 +613,7 @@ static int __init dashtty_init(void) channel_driver->type = TTY_DRIVER_TYPE_SERIAL; channel_driver->subtype = SERIAL_TYPE_NORMAL; channel_driver->init_termios = tty_std_termios; - channel_driver->init_termios.c_cflag = - B38400 | CS8 | CREAD | HUPCL | CLOCAL; + channel_driver->init_termios.c_cflag |= CLOCAL; channel_driver->flags = TTY_DRIVER_REAL_RAW; tty_set_operations(channel_driver, &dashtty_ops);
Ok