Re: [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors

From
Srivatsa S. Bhat <hidden>
Date
2012-06-02 15:35:29
Also in
lkml
Reply to
Sam Ravnborg, 2012-06-02
On 06/02/2012 08:46 PM, Sam Ravnborg wrote:
On Sat, Jun 02, 2012 at 04:11:28AM +0530, Srivatsa S. Bhat wrote:
quoted
On 06/01/2012 10:23 PM, Sam Ravnborg wrote:
quoted
quoted
+
+
+/* Implement the following functions in your architecture, as appropriate. */
+
+/**
+ * __cpu_pre_starting()
+ *
+ * Implement whatever you need to do before the CPU_STARTING notifiers are
+ * invoked. Note that the CPU_STARTING callbacks run *on* the cpu that is
+ * coming up. So that cpu better be prepared! IOW, implement all the early
+ * boot/init code for the cpu here. And do NOT enable interrupts.
+ */
+#ifndef __cpu_pre_starting
+void __weak __cpu_pre_starting(void *arg) {}
+#endif
I miss the prototype for this in a header?

Prototype is not really necessary for this. Hence not added.
There is a simple rule:
1) If a function is declared => not static
2) If function not declared => static

With respect to this simple rule your functions shall be defined as static.
And that would not work.

Fair enough. Will add prototypes in include/linux/smpboot.h

Thanks you!

Regards,
Srivatsa S. Bhat
Thread (81 messages) 81 messages, 12 authors, last reply 2012-06-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help