On 06/01/2012 10:23 PM, Sam Ravnborg wrote:
quoted
+
+
+/* Implement the following functions in your architecture, as appropriate. */
+
+/**
+ * __cpu_pre_starting()
+ *
+ * Implement whatever you need to do before the CPU_STARTING notifiers are
+ * invoked. Note that the CPU_STARTING callbacks run *on* the cpu that is
+ * coming up. So that cpu better be prepared! IOW, implement all the early
+ * boot/init code for the cpu here. And do NOT enable interrupts.
+ */
+#ifndef __cpu_pre_starting
+void __weak __cpu_pre_starting(void *arg) {}
+#endif
I miss the prototype for this in a header?
Prototype is not really necessary for this. Hence not added.
And the comment maybe belong in the header - not in the implementation?
I think having the comment near the implementation itself works better, just
like how it is done at other places in the kernel.
Regards,
Srivatsa S. Bhat