Re: [PATCH 30/30] x32: Add x32 VDSO support

From
Andrew Lutomirski <hidden>
Date
2012-02-21 16:52:42
Also in
lkml
Reply to
H. Peter Anvin, 2012-02-21
On Mon, Feb 20, 2012 at 7:58 PM, H. Peter Anvin [off-list ref] wrote:
On 02/20/2012 04:12 PM, Andy Lutomirski wrote:
quoted
Would it make sense to remove the non-__vdso-prefixed weak symbols?
AFAICT they are somewhere between useless (because the __vdso symbols
are unambiguous), confusing (has anyone not read this and said "huh?"),
and wrong (they are not interchangeable with glibc's symbols as they
return different values).

We're stuck with them on x86-64, but x32 is new and has no
backwards-compatibility issues.
What about non-glibc?
IMO non-glibc users should just call __vdso_clock_gettime, etc.
Currently, code like:

if (clock_gettime(whatever) == -1)
  handle_the_error();

is correct when linked against glibc but incorrect when linked
directly against the vdso.

--Andy
Thread (71 messages) 71 messages, 8 authors, last reply 2012-03-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help