Thread (7 messages) 7 messages, 4 authors, 2011-08-29

Re: [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p)

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2011-08-26 19:42:52
Also in: linux-mm, lkml

On Fri, 26 Aug 2011 10:58:16 +0200
Peter Zijlstra [off-list ref] wrote:
On Fri, 2011-08-26 at 16:17 +0800, Lin Ming wrote:
quoted
The KM_type parameter for kmap_atomic/kunmap_atomic is not used anymore
since commit 3e4d3af(mm: stack based kmap_atomic()).

So convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p).
Most conversion are done by below commands. Some are done by hand.

find . -type f | xargs sed -i 's/\(kmap_atomic(.*\),\ .*)/\1)/'
find . -type f | xargs sed -i 's/\(kunmap_atomic(.*\),\ .*)/\1)/'

Build and tested on 32/64bit x86 kernel(allyesconfig) with 3G memory.

ARM, MIPS, PowerPc and Sparc are build tested only with
CONFIG_HIGHMEM=y and CONFIG_HIGHMEM=n.
I don't have cross-compiler for other arches. 
yet-another-massive patch.. (you're the third or fourth to do so) if
Andrew wants to take this one I won't mind, however previously he didn't
want flag day patches..
I'm OK with cleaning all these up, but I suggest that we leave the
back-compatibility macros in place for a while, to make sure that
various stragglers get converted.  Extra marks will be awarded for
working out how to make unconverted code generate a compile warning ;)

Perhaps you could dust off your old patch and we'll bring it up to date?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help