Re: [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p)

From: Peter Zijlstra <peterz@infradead.org>
Date: 2011-08-26 09:00:17
Also in: linux-mm, lkml

On Fri, 2011-08-26 at 16:17 +0800, Lin Ming wrote:

@@ -292,7 +292,7 @@ static unsigned int bm_bit_to_page_idx(struct drbd_bitmap *b, u64 bitnr)
 static unsigned long *__bm_map_pidx(struct drbd_bitmap *b, unsigned int idx, const enum km_type km)
 {
        struct page *page = b->bm_pages[idx];
-       return (unsigned long *) kmap_atomic(page, km);
+       return (unsigned long *) kmap_atomic(page);
 }
 
 static unsigned long *bm_map_pidx(struct drbd_bitmap *b, unsigned int idx)
@@ -302,7 +302,7 @@ static unsigned long *bm_map_pidx(struct drbd_bitmap *b, unsigned int idx)
 
 static void __bm_unmap(unsigned long *p_addr, const enum km_type km)
 {
-       kunmap_atomic(p_addr, km);
+       kunmap_atomic(p_addr);
 };
  

Stuff like that is really only a half-assed cleanup, IIRC there's more
sites like that.

In my initial massive patch I cleaned all that up as well.