Re: [PATCH 11/24] C6X: interrupt handling
From: Arnd Bergmann <arnd@arndb.de>
Date: 2011-08-09 16:39:48
On Monday 08 August 2011, Mark Salter wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/c6x/kernel/irq.c b/arch/c6x/kernel/irq.c new file mode 100644 index 0000000..252b076 --- /dev/null +++ b/arch/c6x/kernel/irq.c@@ -0,0 +1,736 @@ +/* + * Copyright (C) 2011 Texas Instruments Incorporated + * + * This borrows heavily from powerpc version, which is: + * + * Derived from arch/i386/kernel/irq.c + * Copyright (C) 1992 Linus Torvalds + * Adapted from arch/i386 by Gary Thomas + * Copyright (C) 1995-1996 Gary Thomas (gdt@linuxppc.org) + * Updated and modified by Cort Dougan <cort@fsmlabs.com> + * Copyright (C) 1996-2001 Cort Dougan + * Adapted for Power Macintosh by Paul Mackerras + * Copyright (C) 1996 Paul Mackerras (paulus@cs.anu.edu.au)
There is a lot of work currently going into reworking the way that interrupt controllers work. You have evidently copied the code that was in powerpc, which seems like a reasonably base, but it still duplicates a lot of code. Maybe Thomas can comment on this one and say whether it's still the best solution. If the code is good in the way you implemented it, I think it would be good to move it into some common library in kernel/irq so that both powerpc and c6x as well as future architectures can use the same implementation. Arnd