Re: [PATCH v2] module: deal with alignment issues in built-in module parameters
From: Rusty Russell <hidden>
Date: 2011-02-14 03:52:53
Also in:
linux-m68k, lkml
From: Rusty Russell <hidden>
Date: 2011-02-14 03:52:53
Also in:
linux-m68k, lkml
On Sat, 12 Feb 2011 08:33:56 am Dmitry Torokhov wrote:
quoted
From 03f1332fc02af7af0d06ab409e3ec72107637845 Mon Sep 17 00:00:00 2001From: Dmitry Torokhov <redacted> Date: Mon, 7 Feb 2011 13:47:20 -0800 Subject: [PATCH] module: deal with alignment issues in built-in module parameters As DaveM said, we can't reliably put structures into independent objects, put them into a special section, and then expect array access over them (via the section boundaries) after linking the objects together to just "work" due to variable alignment choices in different situations. The only solution that seems to work reliably is to make an array of plain pointers to the objects in question and put those pointers in the special section.
I've applied this, but won't put it to linux-next. I'll let it stew for a bit longer unless someone actually reports a problem with the current code. Thanks, Rusty.