Re: [PATCH] uapi/fcntl: conditionally define AT_RENAME* macros

On 8/25/25 11:45 AM, Matthew Wilcox wrote:

On Mon, Aug 25, 2025 at 10:52:31AM -0700, Randy Dunlap wrote:

quoted

$ grep -r AT_RENAME_NOREPLACE /usr/include
/usr/include/stdio.h:# define AT_RENAME_NOREPLACE RENAME_NOREPLACE
/usr/include/linux/fcntl.h:#define AT_RENAME_NOREPLACE	0x0001

I have libc 2.42-1.1 (openSUSE).

I wonder if we can fix it by changing include/uapi/linux/fcntl.h
from being an explicit 0x0001 to RENAME_NOREPLACE?  There's probably
a horrendous include problem between linux/fcntl.h and linux/fs.h
though?

I'm working on something like that now (suggested by Amir),
but it might depend on whether stdio.h has been #included first.

-- 
~Randy