Re: [PATCH] uapi/fcntl: conditionally define AT_RENAME* macros

On 8/25/25 6:03 AM, Matthew Wilcox wrote:

On Sun, Aug 24, 2025 at 04:54:50PM -0700, Randy Dunlap wrote:

quoted

In file included from ../samples/vfs/test-statx.c:23:
usr/include/linux/fcntl.h:159:9: warning: ‘AT_RENAME_NOREPLACE’ redefined
  159 | #define AT_RENAME_NOREPLACE     0x0001
In file included from ../samples/vfs/test-statx.c:13:
/usr/include/stdio.h:171:10: note: this is the location of the previous definition
  171 | # define AT_RENAME_NOREPLACE RENAME_NOREPLACE

Oh dear.  This is going to be libc-version-dependent.

I am not surprised at that.

$ grep -r AT_RENAME_NOREPLACE /usr/include
/usr/include/linux/fcntl.h:#define AT_RENAME_NOREPLACE	0x0001

It's not in stdio.h at all.  This is with libc6 2.41-10

It was added 2025-04-22:
2025-04-22  Joseph Myers  [off-list ref]

	COMMIT: cf9241107d12e79073ddb03bab9de115e5e0e856
	Add AT_* constants from Linux 6.12

$ grep -r AT_RENAME_NOREPLACE /usr/include
/usr/include/stdio.h:# define AT_RENAME_NOREPLACE RENAME_NOREPLACE
/usr/include/linux/fcntl.h:#define AT_RENAME_NOREPLACE	0x0001

I have libc 2.42-1.1 (openSUSE).

thanks.
-- 
~Randy