Thread (104 messages) 104 messages, 13 authors, 2023-12-05

Re: [PATCH 03/21] fs/bdev: Add atomic write support info to statx

From: Eric Biggers <ebiggers@kernel.org>
Date: 2023-09-29 22:49:29
Also in: linux-block, linux-fsdevel, linux-nvme, linux-xfs, lkml

On Fri, Sep 29, 2023 at 10:27:08AM +0000, John Garry wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
index 7cab2c65d3d7..c99d7cac2aa6 100644
--- a/include/uapi/linux/stat.h
+++ b/include/uapi/linux/stat.h
@@ -127,7 +127,10 @@ struct statx {
 	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
 	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
 	/* 0xa0 */
-	__u64	__spare3[12];	/* Spare space for future expansion */
+	__u32	stx_atomic_write_unit_max;
+	__u32	stx_atomic_write_unit_min;
Maybe min first and then max?  That seems a bit more natural, and a lot of the
code you've written handle them in that order.
+#define STATX_ATTR_WRITE_ATOMIC		0x00400000 /* File supports atomic write operations */
How would this differ from stx_atomic_write_unit_min != 0?

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help