Thread (107 messages) 107 messages, 6 authors, 2023-01-05

Re: [PATCH v4 01/39] Documentation/x86: Add CET shadow stack description

From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Date: 2022-12-05 21:20:49
Also in: linux-arch, linux-doc, linux-mm, lkml

On Sat, 2022-12-03 at 15:58 +0700, Bagas Sanjaya wrote:
On Fri, Dec 02, 2022 at 04:35:28PM -0800, Rick Edgecombe wrote:
quoted
+An application's CET capability is marked in its ELF note and can
be verified
quoted
+from readelf/llvm-readelf output:
+
+    readelf -n <application> | grep -a SHSTK
+        properties: x86 feature: SHSTK
Shell commands should be inside literal code block (try double
colon).
Above is rendered as definition lists instead.
quoted
+The return values are as following:
+    On success, return 0. On error, errno can be::
Drop indentation on the second line, or better yet, continue the
line,
like "... as following. On success, ..."

Otherwise LGTM, thanks for review. 

In any case,

Reviewed-by: Bagas Sanjaya <redacted>
Sure on both, and thanks for the review.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help