Thread (6 messages) 6 messages, 2 authors, 2022-07-01

Re: [PATCH v3 1/3] fanotify: prepare for setting event flags in ignore mask

From: Amir Goldstein <amir73il@gmail.com>
Date: 2022-07-01 13:32:33
Also in: linux-fsdevel

On Fri, Jul 1, 2022 at 3:47 PM Jan Kara [off-list ref] wrote:
On Wed 29-06-22 17:42:08, Amir Goldstein wrote:
quoted
@@ -529,6 +529,7 @@ struct fsnotify_mark {
      /* fanotify mark flags */
 #define FSNOTIFY_MARK_FLAG_IGNORED_SURV_MODIFY       0x0100
 #define FSNOTIFY_MARK_FLAG_NO_IREF           0x0200
+#define FSNOTIFY_MARK_FLAG_IGNORE_FLAGS              0x0400
      unsigned int flags;             /* flags [mark->lock] */
 };
The whole series looks good to me so I'll test it and queue it up. Just I
find the name FSNOTIFY_MARK_FLAG_IGNORE_FLAGS somewhat confusing because I
had to think whether it means "mark should ignore flags" or whether it
means "ignore mark has flags". So I'll rename this flag to
FSNOTIFY_MARK_FLAG_HAS_IGNORE_FLAGS on commit.
Excellent.
Thanks!

Amir.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help