Re: [PATCH v3 1/3] fanotify: prepare for setting event flags in ignore mask
From: Jan Kara <jack@suse.cz>
Date: 2022-07-01 12:47:58
Also in:
linux-fsdevel
On Wed 29-06-22 17:42:08, Amir Goldstein wrote:
quoted hunk ↗ jump to hunk
@@ -529,6 +529,7 @@ struct fsnotify_mark { /* fanotify mark flags */ #define FSNOTIFY_MARK_FLAG_IGNORED_SURV_MODIFY 0x0100 #define FSNOTIFY_MARK_FLAG_NO_IREF 0x0200 +#define FSNOTIFY_MARK_FLAG_IGNORE_FLAGS 0x0400 unsigned int flags; /* flags [mark->lock] */ };
The whole series looks good to me so I'll test it and queue it up. Just I find the name FSNOTIFY_MARK_FLAG_IGNORE_FLAGS somewhat confusing because I had to think whether it means "mark should ignore flags" or whether it means "ignore mark has flags". So I'll rename this flag to FSNOTIFY_MARK_FLAG_HAS_IGNORE_FLAGS on commit. Honza -- Jan Kara [off-list ref] SUSE Labs, CR