Re: [PATCH v4 3/3] gen_init_cpio: add support for file metadata
flat view
From: Eugeniu Rosca <hidden>
Date: 2022-06-16 14:48:30
Also in:
linux-fsdevel, linux-integrity, linux-security-module, lkml
Hello Roberto, On Do, Mai 23, 2019 at 02:18:03 +0200, Roberto Sassu wrote:
quoted hunk ↗ jump to hunk
This patch adds support for file metadata (only TYPE_XATTR metadata type). gen_init_cpio has been modified to read xattrs from files that will be added to the image and to include file metadata as separate files with the special name 'METADATA!!!'. This behavior can be selected by setting the desired file metadata type as value for CONFIG_INITRAMFS_FILE_METADATA. Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> --- usr/Kconfig | 8 +++ usr/Makefile | 4 +- usr/gen_init_cpio.c | 137 ++++++++++++++++++++++++++++++++++++-- usr/gen_initramfs_list.sh | 10 ++- 4 files changed, 150 insertions(+), 9 deletions(-)diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c index 03b21189d58b..e93cb1093e77 100644 --- a/usr/gen_init_cpio.c +++ b/usr/gen_init_cpio.c
[..]
+static int write_xattrs(const char *path)
+{[..]
quoted hunk ↗ jump to hunk
+ + snprintf(str, sizeof(str), "%.8lx", + sizeof(hdr) + name_len + 1 + value_len);
Cppcheck 2.7 reports at this line:
usr/gen_init_cpio.c:107,portability,invalidPrintfArgType_uint,%lx in format string (no. 1) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'.
This can be addressed via 's/lx/zx/', according to https://www.kernel.org/doc/Documentation/printk-formats.txt .
BR, Eugeniu