Re: [PATCH v4 0/3] block: show crypto capabilities in sysfs

On Mon, Jan 24, 2022 at 01:59:35PM -0800, Eric Biggers wrote:

This series adds sysfs files that expose the inline encryption
capabilities of request queues.

Patches 1 and 2 are some related cleanups for existing blk-sysfs code.
Patch 3 is the real change; see there for more details.

This series applies to v5.17-rc1.

Changed v3 => v4:
   - Reworded a comment in patch 2.
   - Updated dates in sysfs documentation.
   - Added more Reviewed-by tags.

Changed v2 => v3:
   - Moved the documentation into Documentation/ABI/stable/sysfs-block,
     and improved it a bit.
   - Write "/sys/block/" instead of "/sys/class/block/".
   - Added Reviewed-by tags.

Changed v1 => v2:
   - Use sysfs_emit() instead of sprintf().
   - Use __ATTR_RO().

Eric Biggers (3):
  block: simplify calling convention of elv_unregister_queue()
  block: don't delete queue kobject before its children
  blk-crypto: show crypto capabilities in sysfs

Any more feedback on this?

- Eric