Thread (9 messages) 9 messages, 3 authors, 2022-02-28

Re: [PATCH v4 1/3] block: simplify calling convention of elv_unregister_queue()

From: Christoph Hellwig <hch@infradead.org>
Date: 2022-01-25 08:51:07
Also in: linux-block, linux-mmc, linux-scsi, lkml

On Mon, Jan 24, 2022 at 01:59:36PM -0800, Eric Biggers wrote:
From: Eric Biggers <redacted>

Make elv_unregister_queue() a no-op if q->elevator is NULL or is not
registered.

This simplifies the existing callers, as well as the future caller in
the error path of blk_register_queue().

Also don't bother checking whether q is NULL, since it never is.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Eric Biggers <redacted>
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help