Re: [PATCH] corrent sys_reboot annotation

On Fri, Jul 30, 2021 at 03:00:47PM +0800, Zicheng Wang wrote:

在 2021/7/30 14:54, Greg KH 写道:

quoted

On Fri, Jul 30, 2021 at 02:40:32PM +0800, Wang Zi-cheng wrote:

quoted

Signed-off-by: Wang Zi-cheng <redacted>

You forgot a changelog text :(

Sorry, and what should I write for a changelog?

You tell me, you are the one that determined this needed a change, not
me :)

Also, your subject is odd and needs to be fixed, please see the
documentation for how to write good kernel changelogs and subject lines.

Also, when starting out, I would recommend working in the
drivers/staging/ part of the kernel until you learn these basic skills
as that is the part of the kernel best for that.

thanks,

greg k-h