Re: [PATCH v21 06/26] x86/cet: Add control-protection fault handler

On 2/24/2021 8:53 AM, Borislav Petkov wrote:

On Wed, Feb 24, 2021 at 08:44:45AM -0800, Yu, Yu-cheng wrote:

quoted

quoted

quoted

+	force_sig_fault(SIGSEGV, SEGV_CPERR,
+			(void __user *)uprobe_get_trap_addr(regs));

Why is this calling an uprobes function?

I will change it to error_get_trap_addr().

"/*
   * Posix requires to provide the address of the faulting instruction for
   * SIGILL (#UD) and SIGFPE (#DE) in the si_addr member of siginfo_t.
   ..."

Is yours SIGILL or SIGFPE?

No.  Maybe I am doing too much.  The GP fault sets si_addr to zero, for 
example.  So maybe do the same here?