Re: [PATCH v17 04/26] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions

On 1/12/2021 4:38 AM, Borislav Petkov wrote:

On Mon, Jan 11, 2021 at 03:09:00PM -0800, Yu-cheng Yu wrote:

quoted

@@ -1252,6 +1260,16 @@ static void __init cpu_parse_early_param(void)
  	if (cmdline_find_option_bool(boot_command_line, "noxsaves"))
  		setup_clear_cpu_cap(X86_FEATURE_XSAVES);
  
+	/*
+	 * CET states are XSAVES states and options must be parsed early.
+	 */

That comment is redundant - look at the containing function's name.

Otherwise patch looks just as it should.

Thx.

Should I send an updated patch?  Thanks!

--
Yu-cheng